Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(214)

Issue 157066: cmd/cc: change getquoted() to accept whitespaces. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by sergio (larces)
Modified:
15 years, 4 months ago
Reviewers:
rsc
Visibility:
Public.

Description

cmd/cc: change getquoted() to accept whitespaces. getquoted() currently checks for whitespaces and returns nil if it finds one. this prevents us from having go in a path containing whitespaces, as the #pragma dynld directives are processed through the said function. this commit makes getquoted() accept whitespaces, and this is also needed for solving issue #115.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/cc/dpchk.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
rsc
LGTM
15 years, 4 months ago (2009-11-23 23:48:49 UTC) #1
rsc
15 years, 4 months ago (2009-11-24 00:00:28 UTC) #2
*** Submitted as http://code.google.com/p/go/source/detail?r=77ab01e09eb7 ***

cmd/cc: change getquoted() to accept whitespaces.

getquoted() currently checks for whitespaces and returns nil
if it finds one. this prevents us from having go in a path
containing whitespaces, as the #pragma dynld directives are
processed through the said function.

this commit makes getquoted() accept whitespaces, and this is
also needed for solving issue #115.

R=rsc
http://codereview.appspot.com/157066

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b