Issue 155860043: Issue 2010: \lyricsto may turn into a voice-mangling zombie

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 155860043: Issue 2010: \lyricsto may turn into a voice-mangling zombie (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 6 months ago by dak

Modified:
9 years, 6 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 2010: \lyricsto may turn into a voice-mangling zombie The problem here was that the simultaneous iterator might keep rerhythmed lyrics around when the associated voice has died already, blocking the simultaneous iterator. The solution is that when removing the last regular iterator to remove all remaining lyric-combined iterators at the same time.

Patch Set 1 #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
	M	lily/simultaneous-music-iterator.cc	View		1 chunk	+30 lines, -3 lines	0 comments	Download