Issue 1543: Use tempfile instead of ad-hoc temporary file

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1543: Use tempfile instead of ad-hoc temporary file

Can't Edit
Can't Publish+Mail
Start Review

Created:
18 years ago by Robert Kern

Modified:
11 years, 10 months ago

Reviewers:
ondrej.certik, pgmdevlist

Base URL:
http://svn.scipy.org/svn/numpy/trunk/

Visibility:
Public.

Description

Instead of make a timestamp-based filename using strftime, just use tempfile.mkstemp(). It's safer, since the current working directory may not be writable. Also, we just got a bug report from someone using VS 2008 to build numpy; with that C runtime's implementation of strftime, the %s format code does not appear to be valid.

Patch Set 1 #

Created: 18 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
		numpy/ma/tests/test_mrecords.py	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ondrej.certik

18 years ago (2008-06-03 20:33:25 UTC) #2

Excellent, now it is much simpler and more robust. +1

Ondrej

Expand All Messages | Collapse All Messages