Issue 154106: Fix for <script type="os/data"> elements in <head> ending up blank.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154106: Fix for <script type="os/data"> elements in <head> ending up blank. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 10 months ago by johnfargo

Modified:
15 years, 9 months ago

Reviewers:
Paul Lindner, shindig.remailer

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

The Neko parser disallows children of <head> elements from having children of their own. Thus OSData elements must appear in <body> to avoid their children from being pulled outside the <script> element itself. Thanks to Paul Lindner for distilling this to a unit test (included). Hopefully this doesn't break any other OSData requirements..

Patch Set 1 #

Created: 15 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/nekohtml/NekoSimplifiedHtmlParser.java	View		1 chunk	+3 lines, -3 lines	0 comments	Download
		java/gadgets/src/test/resources/org/apache/shindig/gadgets/parse/nekohtml/test-socialmarkup.html	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Looks good.  Tested on a number of specs.

Expand All Messages | Collapse All Messages