Issue 154054: Use W3C formula for luminance comparison of line colors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154054: Use W3C formula for luminance comparison of line colors

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by Arno Eigenwillig

Modified:
14 years, 10 months ago

Reviewers:
Tom

CC:
googletransitdatafeed_googlegroups.com

Base URL:
http://googletransitdatafeed.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This change provides a partial fix for http://code.google.com/p/googletransitdatafeed/issues/detail?id=108

Patch Set 1 #

Total comments: 2

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -17 lines)			Patch
	M	python/test/testtransitfeed.py	View		1 chunk	+14 lines, -8 lines	2 comments	Download
	M	python/transitfeed.py	View		3 chunks	+16 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Arno Eigenwillig

Hi Tom, please have a look at the fix for the transitfeed bug you sent ...

14 years, 10 months ago (2009-11-11 17:51:25 UTC) #1

Tom

Looks good. http://codereview.appspot.com/154054/diff/1/2 File python/test/testtransitfeed.py (right): http://codereview.appspot.com/154054/diff/1/2#newcode606 python/test/testtransitfeed.py:606: pass delete this while you are here

14 years, 10 months ago (2009-11-11 18:28:57 UTC) #2

Arno Eigenwillig

14 years, 10 months ago (2009-11-11 19:08:47 UTC) #3

Thanks for your quick review!  I'm going to submit after rerunning nosetests.

http://codereview.appspot.com/154054/diff/1/2
File python/test/testtransitfeed.py (right):

http://codereview.appspot.com/154054/diff/1/2#newcode606
python/test/testtransitfeed.py:606: pass
On 2009/11/11 18:28:57, Tom wrote:
> delete this while you are here

Done.

Expand All Messages | Collapse All Messages