Issue 153050044: Rietveld-codereview

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 153050044: Rietveld-codereview

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by jawadmunir713

Modified:
9 years, 7 months ago

Reviewers:
mihretgetye, gsav, dkostic, anacha, don1559, kirillb, ada.t.ge

CC:
jawadmunir713, gsav_kth.se

Visibility:
Public.

More Reviews

Description

hi-my-first-commit

Patch Set 1 #

Patch Set 2 : hi its jawad #

Patch Set 3 : first commit to Rietveld #

Total comments: 1

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	contributors.txt	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

don1559

9 years, 7 months ago (2014-10-05 19:42:56 UTC) #3

Done review.
Ahmed

https://codereview.appspot.com/153050044/diff/40001/contributors.txt
File contributors.txt (right):

https://codereview.appspot.com/153050044/diff/40001/contributors.txt#newcode17
contributors.txt:17: branch-first
Review done. Accepted.

Expand All Messages | Collapse All Messages