Issue 153044: [PATCH] Move stub allocation to the JITEmitter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 153044: [PATCH] Move stub allocation to the JITEmitter (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by Jeffrey Yasskin

Modified:
14 years, 4 months ago

Reviewers:
echristo

CC:
llvm-commits_cs.uiuc.edu

Visibility:
Public.

Description

* Move stub allocation inside the JITEmitter, instead of exposing a way for each TargetJITInfo subclass to allocate its own stubs. This means stubs aren't as exactly-sized anymore, but it lets us get rid of TargetJITInfo::emitFunctionStubAtAddr(), which lets ARM and PPC support the eager JIT, fixing http://llvm.org/PR4816. * Rename the JITEmitter's stub creation functions to describe the kind of stub they create. So far, all of them create lazy-compilation stubs, but they sometimes get used when far-call stubs are needed. That'll be fixed in a future patch.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+271 lines, -177 lines)			Patch
M	include/llvm/CodeGen/JITCodeEmitter.h	View	1 2 3 4	1 chunk	+17 lines, -11 lines	0 comments	Download
M	include/llvm/CodeGen/MachineCodeEmitter.h	View		1 chunk	+34 lines, -10 lines	0 comments	Download
M	include/llvm/Target/TargetJITInfo.h	View	1 2 3 4	2 chunks	+17 lines, -10 lines	0 comments	Download
M	lib/ExecutionEngine/JIT/JITEmitter.cpp	View	1 2 3 4	19 chunks	+72 lines, -68 lines	0 comments	Download
M	lib/Target/ARM/ARMJITInfo.h	View	1 2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	lib/Target/ARM/ARMJITInfo.cpp	View	1 2 3 4	5 chunks	+30 lines, -21 lines	0 comments	Download
M	lib/Target/Alpha/AlphaJITInfo.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/Target/Alpha/AlphaJITInfo.cpp	View	1 2 3 4	1 chunk	+11 lines, -2 lines	0 comments	Download
M	lib/Target/PowerPC/PPCJITInfo.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/Target/PowerPC/PPCJITInfo.cpp	View	1 2 3 4	4 chunks	+16 lines, -9 lines	0 comments	Download
M	lib/Target/X86/X86JITInfo.h	View	1 2 3 4	1 chunk	+5 lines, -7 lines	0 comments	Download
M	lib/Target/X86/X86JITInfo.cpp	View	1 2 3 4	1 chunk	+29 lines, -36 lines	0 comments	Download
M	unittests/ExecutionEngine/JIT/JITTest.cpp	View	1 2 3 4	5 chunks	+34 lines, -3 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Jeffrey Yasskin

14 years, 5 months ago (2009-11-12 23:34:58 UTC) #1

This overlaps with http://codereview.appspot.com/154066 (far calls in x86 large
code model) some; I'll merge whichever gets committed second.

I got nlewycky to confirm that the re-enabled tests do actually pass on arm and
ppc.

Expand All Messages | Collapse All Messages