Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(183)

Issue 153042: Sun Studio 11 & 12 Support on Solaris

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 7 months ago by Hady
Modified:
11 years, 8 months ago
Reviewers:
Vlad, wan
CC:
googletestframework_googlegroups.com
Base URL:
http://googletest.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Solaris 5.8 Support #

Total comments: 26

Patch Set 3 : Updated Patch With Suggested Comments #

Total comments: 11

Patch Set 4 : Updated Patch Set with Vlad's Suggestions #

Total comments: 4

Patch Set 5 : Updated Patch Set for Last Nits #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -67 lines) Patch
M include/gtest/gtest-typed-test.h View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M include/gtest/internal/gtest-port.h View 1 2 5 chunks +10 lines, -5 lines 0 comments Download
M include/gtest/internal/gtest-tuple.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M include/gtest/internal/gtest-tuple.h.pump View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/gtest-port.cc View 2 1 chunk +9 lines, -2 lines 0 comments Download
M src/gtest-typed-test.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M test/gtest-port_test.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M test/gtest_break_on_failure_unittest.py View 2 1 chunk +6 lines, -4 lines 0 comments Download
M test/gtest_env_var_test.py View 2 3 chunks +6 lines, -4 lines 0 comments Download
M test/gtest_filter_unittest.py View 2 3 4 5 chunks +42 lines, -12 lines 0 comments Download
M test/gtest_output_test.py View 1 2 4 chunks +22 lines, -15 lines 0 comments Download
M test/gtest_shuffle_test.py View 2 3 1 chunk +4 lines, -10 lines 0 comments Download
M test/gtest_test_utils.py View 2 3 3 chunks +27 lines, -2 lines 0 comments Download
M test/gtest_unittest.cc View 1 2 11 chunks +31 lines, -9 lines 1 comment Download

Messages

Total messages: 8
Vlad
Hi Hady, I have some comments on the path. In some places I ask you ...
16 years, 7 months ago (2009-11-10 21:40:24 UTC) #1
Hady
Hi Vlad, I uploaded a new patch set taking your suggestions into account. Could you ...
16 years, 7 months ago (2009-11-11 14:44:26 UTC) #2
Vlad
Nice, we are close! I have a just a few more comments. I have also ...
16 years, 7 months ago (2009-11-16 02:01:26 UTC) #3
Hady
Thanks! Yeah, sure for the upcoming changes. I'll keep an eye out. Don't hesitate to ...
16 years, 7 months ago (2009-11-16 11:50:16 UTC) #4
Vlad
Hi Hady, Just a couple of nits now. Do you plan to post AIX changes ...
16 years, 7 months ago (2009-11-16 15:51:06 UTC) #5
Hady
Great! I was actually going to submit the AIX patch in another issue once these ...
16 years, 7 months ago (2009-11-16 19:22:59 UTC) #6
Vlad
Hi Hady, The patch looks good now. I will touch it up myself to make ...
16 years, 7 months ago (2009-11-18 06:42:19 UTC) #7
Vlad
16 years, 4 months ago (2010-02-02 00:39:39 UTC) #8
Hady,

I've got another question on the patch.

In other news, the Python test script changes cause some tests to crash on some
of our Windows build machines, so we'll split the patch into two parts and
commit only the C++ one while we are investigating.

http://codereview.appspot.com/153042/diff/2034/3039
File test/gtest_unittest.cc (right):

http://codereview.appspot.com/153042/diff/2034/3039#newcode1387
test/gtest_unittest.cc:1387: #if !defined(__SUNPRO_CC) || __SUNPRO_CC >= 0x590
Do you know which part of the code is rejected? What are the error messages? Is
there a way to fix the code to work with the Sun compiler?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b