Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(583)

Issue 152070: 3xx shouldn't be classified as errors in gadgets.io.makeRequest (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by johnfargo
Modified:
15 years, 10 months ago
Reviewers:
beaton, Jon Weygandt, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

This patch removes the classification of 3xx responses as errors (populating resp.errors) in gadgets.io.makeRequest. To avoid incorrectly parsing 3xx response content (often HTML snippets), such responses are treated as TEXT.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
features/src/main/javascript/features/core.io/io.js View 1 chunk +8 lines, -1 line 1 comment Download

Messages

Total messages: 4
johnfargo
15 years, 10 months ago (2009-11-11 19:23:40 UTC) #1
beaton
I took a look, and the rest of SHINDIG-1180 looks reasonable. Thanks for fixing this. ...
15 years, 10 months ago (2009-11-11 19:32:58 UTC) #2
Jon Weygandt
Are there valid use cases where the 3xx status codes would be used by a ...
15 years, 10 months ago (2009-11-11 20:29:55 UTC) #3
Jon Weygandt
15 years, 10 months ago (2009-11-11 20:54:14 UTC) #4
Is it clear from the OS specification that redirects should (or should not be)
followed?

Would this be something that we would want to add, along with perhaps a
parameter to turn it on/off?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b