Issue 152058: add WIFI_PHY_STANDARD_80211p_CCH and SCH

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 152058: add WIFI_PHY_STANDARD_80211p_CCH and SCH

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by nowatkom

Modified:
15 years, 5 months ago

Reviewers:
Mathieu Lacage

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : add WIFI_PHY_STANDARD_80211p_CCH and SCH #

Patch Set 3 : add WIFI_PHY_STANDARD_80211p_CCH and SCH #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -2 lines)			Patch
M	src/devices/wifi/qap-wifi-mac.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/devices/wifi/qsta-wifi-mac.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/devices/wifi/yans-wifi-phy.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Mathieu Lacage

The patchs looks good modulo my minor comments/questions below. Once you have resolved these, I ...

15 years, 5 months ago (2009-11-17 12:05:35 UTC) #1

nowatkom

15 years, 5 months ago (2009-11-18 03:20:17 UTC) #2

I added the changes to qap-wifi-mac.cc and qsta-wifi-mac.cc (see Patch Set 2).

802.11p is specifically set to work on channels 172-184 (center freq of 5.860
GHz for channel 172).  I would recommend leaving the starting frequency at 5.0
GHz.  Yes, the comment was a copy/paste from the the 10MHz code.  Should I
remove the comment?

Thanks!
  Michael

On 2009/11/17 12:05:35, Mathieu Lacage wrote:

Expand All Messages | Collapse All Messages