Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(277)

Issue 151630043: code review 151630043: test: add more cases to recover.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by iant
Modified:
9 years, 6 months ago
Reviewers:
bradfitz
CC:
golang-codereviews, bradfitz
Visibility:
Public.

Description

test: add more cases to recover.go test16 used to fail with gccgo. The withoutRecoverRecursive test would have failed in some possible implementations.

Patch Set 1 #

Patch Set 2 : diff -r bfa1d5c8d09a2bef6577e45062d1e7bd7c182009 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M test/recover.go View 3 chunks +41 lines, -3 lines 0 comments Download

Messages

Total messages: 4
iant
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2014-10-09 14:17:44 UTC) #1
iant
Ping.
9 years, 6 months ago (2014-10-21 16:26:27 UTC) #2
bradfitz
LGTM On Oct 21, 2014 6:26 PM, <iant@golang.org> wrote: > Ping. > > https://codereview.appspot.com/151630043/ > ...
9 years, 6 months ago (2014-10-22 13:38:39 UTC) #3
iant
9 years, 6 months ago (2014-10-22 15:06:19 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=366de8a6a8cf ***

test: add more cases to recover.go

test16 used to fail with gccgo.  The withoutRecoverRecursive
test would have failed in some possible implementations.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/151630043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b