Issue 151051: [PATCH] Make the need-stub variables accurate and consistent

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 151051: [PATCH] Make the need-stub variables accurate and consistent (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by Jeffrey Yasskin

Modified:
14 years, 6 months ago

Reviewers:

CC:
llvm-commits_cs.uiuc.edu

Visibility:
Public.

Description

I'm trying to tease apart the different uses for "stubs" in the JIT. In the case of MachineRelocations, I believe "stub" always refers to a far-call stub or a load-a-faraway-global stub, so this patch adds "Far" to the term. The variable was also inconsistent between the positive and negative sense, and the positive sense ("NeedStub") was more demanding than is accurate (since a nearby-enough function can be called directly even if the platform often requires a stub). Since the negative sense causes double-negatives, I switched to "MayNeedFarStub" globally.

Patch Set 1 #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -48 lines)			Patch
M	include/llvm/CodeGen/MachineRelocation.h	View	10 chunks	+17 lines, -15 lines	0 comments	Download
M	lib/ExecutionEngine/JIT/JITEmitter.cpp	View	7 chunks	+13 lines, -15 lines	0 comments	Download
M	lib/Target/ARM/ARMCodeEmitter.cpp	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	lib/Target/X86/X86CodeEmitter.cpp	View	8 chunks	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Jeffrey Yasskin

14 years, 6 months ago (2009-11-07 05:30:10 UTC) #1

Please take a look.

I'd like to find an example of a global-variable far stub to put in the comment
for MachineRelocation::mayNeedFarStub(). Can anyone describe the requirement for
ARM or another platform so I can copy it in?

Expand All Messages | Collapse All Messages