Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(91)

Issue 151041: include line number in each change header in mail

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 weeks, 1 day ago by rsc_swtch
Modified:
4 weeks, 1 day ago
Reviewers:
GvR
CC:
SVN Base:
http://rietveld.googlecode.com/svn/trunk/codereview/
Visibility:
Public.

Description

When reading the mail from a very long review,
it is difficult, looking at a single comment that
says Line 123, to scan backward in the mail to
find the immediately preceding File line.  All the
stanzas look about the same.

This patch changes the introductory text from

Line 123:

to

filename:123:

as is commonly used for compiler error messages
and the like.  This avoids the problem of having
to scan backward to figure out which file is being
discussed.

The problem is particularly acute when you get a
batch of replies that is maybe 25 "Done." across
a few different files and you see the one substantial
reply and can't immediately match it to a file.

Patch Set 1

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M views.py View 1 chunk 13 lines 0 comments Download

Messages

Total messages: 2
rsc_swtch
4 weeks, 1 day ago
GvR
4 weeks, 1 day ago
LG.

Submitted as r483 and made live on codereview.appspot.com.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld r497