Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1146)

Issue 1501: Upload base files (SVN, files > 1MB) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
18 years ago by Andi
Modified:
13 years, 10 months ago
Reviewers:
ondrej.certik, JohnA, GvR
Base URL:
http://rietveld.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adds an option to upload.py to push base files from a local subversion repository to codereview.

Patch Set 1 #

Patch Set 2 : More exception handling on server-side #

Patch Set 3 : Bug fixes, form handling, content handling #

Patch Set 4 : Edit form fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -21 lines) Patch
codereview/engine.py View 2 3 2 chunks +8 lines, -1 line 0 comments Download
codereview/models.py View 1 2 3 4 chunks +32 lines, -2 lines 0 comments Download
codereview/urls.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
codereview/views.py View 1 2 3 9 chunks +155 lines, -12 lines 0 comments Download
static/upload.py View 1 2 3 4 chunks +72 lines, -4 lines 2 comments Download
templates/edit.html View 1 chunk +6 lines, -0 lines 0 comments Download
templates/issue.html View 3 chunks +3 lines, -1 line 0 comments Download
templates/issue_base.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13
Andi Albrecht
As I've said in the discussion group, this patch is working but not ready to ...
18 years ago (2008-06-01 05:41:14 UTC) #1
GvR
Would it be possible to submit the server-side code (and make it live) piecemeal, to ...
18 years ago (2008-06-01 17:23:50 UTC) #2
ondrej.certik
> Would it be possible to submit the server-side code (and > make it live) ...
18 years ago (2008-06-04 15:48:47 UTC) #3
Andi Albrecht
This version has some more exception handling on the server side. I didn't make any ...
18 years ago (2008-06-04 21:43:55 UTC) #4
GvR
Here are some comments. I'll have more later. http://codereview.appspot.com/1501/diff/141/164 File codereview/engine.py (right): http://codereview.appspot.com/1501/diff/141/164#newcode92 Line 92: ...
18 years ago (2008-06-06 18:39:42 UTC) #5
ondrej.certik
http://codereview.appspot.com/1501/diff/141/161 File static/upload.py (right): http://codereview.appspot.com/1501/diff/141/161#newcode558 Line 558: content = f.read() On 2008/06/06 18:39:42, GvR wrote: ...
18 years ago (2008-06-07 13:26:33 UTC) #6
Andi Albrecht
While reading your comments and modifying the source I came across some other parts that ...
18 years ago (2008-06-10 19:31:00 UTC) #7
Andi Albrecht
While reading your comments and modifying the source I came across some other parts that ...
18 years ago (2008-06-10 19:31:24 UTC) #8
Andi Albrecht
Hi Guido, the latest patch set fixes a problem with the issue edit form and ...
17 years, 11 months ago (2008-06-21 05:02:13 UTC) #9
JohnA
I've tried it out and it works well. However, one issue was when a file ...
17 years, 11 months ago (2008-06-23 20:29:00 UTC) #10
Andi Albrecht
http://codereview.appspot.com/1501/diff/561/581 File static/upload.py (right): http://codereview.appspot.com/1501/diff/561/581#newcode565 Line 565: sys.exit(False) On 2008/06/23 20:29:01, john.abdelmalek wrote: > # ...
17 years, 11 months ago (2008-06-24 03:54:37 UTC) #11
JohnA
Up to you. Although it'd be nice (for me!) if you can check this in, ...
17 years, 11 months ago (2008-06-24 04:15:14 UTC) #12
Andi Albrecht
17 years, 11 months ago (2008-06-24 04:30:47 UTC) #13
There are other parts in upload.py and on the server side I would like to test.
As it shouldn't be very complicated to implement support for svn1.5 features it
might go in before the uploading of base files feature.

On 2008/06/24 04:15:14, john.abdelmalek wrote:
> Up to you.  Although it'd be nice (for me!) if you can check this in, because
> otherwise it'll fail for people using 1.5...  It looks harmless otherwise, no?
> 
> On 2008/06/24 03:54:37, andi.albrecht wrote:
> > http://codereview.appspot.com/1501/diff/561/581
> > File static/upload.py (right):
> > 
> > http://codereview.appspot.com/1501/diff/561/581#newcode565
> > Line 565: sys.exit(False)
> > On 2008/06/23 20:29:01, john.abdelmalek wrote:
> > > #  If file is in a changelist, The first line will be "--- Changelist
> > > 'cl_name':".
> > >     if status[0:4] == "\n---":
> > >       index = status.find('\n', 1)
> > >       if index != -1:
> > >         status = status[index + 1:]
> > 
> > Thanks for the hint! I would like to make support for new Subversion 1.5
> > features a separate topic. For now I'm running 1.4 clients on all of my
> machines
> > and even if it shouldn't be a problem to use a 1.5 client with a 1.4
> repository
> > I would prefer to do some tests before migrating and integrating 1.5
features
> in
> > upload.py...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b