Issue 150055: [issue3001] RLock's are SLOW

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 150055: [issue3001] RLock's are SLOW

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by gregory.p.smith

Modified:
15 years, 2 months ago

Reviewers:
Antoine Pitrou

CC:
report_bugs.python.org

Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/

Visibility:
Public.

Description

code review for http://bugs.python.org/issue3001

Patch Set 1 #

Total comments: 4

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+273 lines, -7 lines)			Patch
M	Lib/test/test_threading.py	View	3 chunks	+8 lines, -5 lines	0 comments	Download
M	Lib/threading.py	View	3 chunks	+12 lines, -2 lines	0 comments	Download
M	Modules/_threadmodule.c	View	3 chunks	+253 lines, -0 lines	4 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

gregory.p.smith

http://codereview.appspot.com/150055/diff/1/4 File Modules/_threadmodule.c (right): http://codereview.appspot.com/150055/diff/1/4#newcode221 Modules/_threadmodule.c:221: return PyBool_FromLong((long) r); This explicit (long) cast is unnecessary. ...

15 years, 2 months ago (2009-11-07 07:48:04 UTC) #1

Antoine Pitrou

15 years, 2 months ago (2009-11-07 15:06:51 UTC) #2

Thanks for the review. I will make the suggested modifications.

http://codereview.appspot.com/150055/diff/1/4
File Modules/_threadmodule.c (right):

http://codereview.appspot.com/150055/diff/1/4#newcode221
Modules/_threadmodule.c:221: return PyBool_FromLong((long) r);
On 2009/11/07 07:48:05, gregory.p.smith wrote:
> This explicit (long) cast is unnecessary.

Right.

http://codereview.appspot.com/150055/diff/1/4#newcode246
Modules/_threadmodule.c:246: PyThread_release_lock(self->rlock_lock);
On 2009/11/07 07:48:05, gregory.p.smith wrote:
> reset self->rlock_owner to 0 before releasing the lock.

We always check rlock_count before rlock_owner anyway but, yes, I could reset
rlock_owner out of safety.

Expand All Messages | Collapse All Messages