Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1052)

Issue 150054: Updated NPAPI headers to latest from mozilla.

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by apatrick
Modified:
14 years, 5 months ago
Reviewers:
Antoine Labour, piman
Base URL:
http://nixysa.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Unfortunately this is a breaking change for existing users. Specifically npupp.h was renamed to npfunctions.h and the members of NPString were renamed from utf8characters and utf8length to UTF8Characters and UTF8Length and perhaps some other things I didn't notice. This is a nuisance but O3D needs the latest additions to NPAPI.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+587 lines, -263 lines) Patch
M nixysa/pod_binding.py View 2 chunks +4 lines, -4 lines 0 comments Download
M nixysa/static_glue/npapi/common.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M nixysa/static_glue/npapi/npn_api.h View 1 chunk +1 line, -1 line 0 comments Download
M nixysa/static_glue/npapi/npn_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/npapi/include/npapi.h View 22 chunks +244 lines, -229 lines 0 comments Download
A third_party/npapi/include/npfunctions.h View 1 chunk +296 lines, -0 lines 0 comments Download
M third_party/npapi/include/npruntime.h View 4 chunks +22 lines, -20 lines 0 comments Download
M third_party/npapi/include/nptypes.h View 4 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 3
apatrick
The samples don't build with my setup. It might be because I'm using VS 2008 ...
14 years, 5 months ago (2009-11-07 00:01:30 UTC) #1
piman
LGTM. Can you just send a quick e-mail to nixysa-users about the change ?
14 years, 5 months ago (2009-11-07 01:27:52 UTC) #2
apatrick
14 years, 5 months ago (2009-11-07 04:18:50 UTC) #3
Will do.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b