Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 148350043: Use Xxx:is_smob instead of Xxx:unsmob when used in boolean contexts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Use Xxx:is_smob instead of Xxx:unsmob when used in boolean contexts This saves a memory access and comparison and leads to better code even when unsmob is called afterwards anyway. Also contains commit: Define inline members unsmob and is_smob for several derived classes

Patch Set 1 #

Patch Set 2 : A few oversights regarding unsmob->is_smob #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -235 lines) Patch
M lily/accidental-placement.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/ambitus-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/axis-group-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/axis-group-interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/bar-check-iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/beam-collision-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/beam-quanting.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/book.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/break-alignment-interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/break-substitution.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M lily/chord-name-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/context-property.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/dots-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/engraver.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M lily/engraver-scheme.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/fingering-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/function-documentation.cc View 1 2 chunks +7 lines, -11 lines 0 comments Download
M lily/global-context.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M lily/global-context-scheme.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M lily/grob.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/grob-closure.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/grob-info.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/grob-property.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M lily/grob-scheme.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/include/engraver.hh View 1 chunk +6 lines, -1 line 0 comments Download
M lily/include/global-context.hh View 1 chunk +6 lines, -1 line 0 comments Download
M lily/include/item.hh View 1 chunk +6 lines, -1 line 0 comments Download
M lily/include/lily-guile-macros.hh View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/include/music.hh View 1 chunk +6 lines, -1 line 0 comments Download
M lily/include/paper-score.hh View 1 chunk +6 lines, -1 line 0 comments Download
M lily/include/performance.hh View 1 chunk +6 lines, -1 line 0 comments Download
M lily/include/performer.hh View 1 chunk +6 lines, -1 line 0 comments Download
M lily/include/smobs.tcc View 1 1 chunk +1 line, -1 line 0 comments Download
M lily/include/spanner.hh View 1 chunk +6 lines, -1 line 0 comments Download
M lily/include/stream-event.hh View 1 chunk +6 lines, -1 line 0 comments Download
M lily/input-scheme.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M lily/item.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M lily/item-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/lexer.ll View 3 chunks +3 lines, -3 lines 0 comments Download
M lily/lily-lexer.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/multi-measure-rest.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/music.cc View 2 chunks +1 line, -7 lines 0 comments Download
M lily/music-function-scheme.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/music-scheme.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M lily/new-fingering-engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/note-column.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/note-heads-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/note-performer.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/note-spacing-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/page-layout-problem.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/paper-book.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M lily/paper-column.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/paper-column-engraver.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/paper-score.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M lily/paper-score-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/parser.yy View 21 chunks +31 lines, -31 lines 0 comments Download
M lily/performance.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M lily/performance-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/performer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M lily/pitched-trill-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/pointer-group-interface-scheme.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/prob.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/pure-from-neighbor-interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/scm-hash.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/score.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/side-position-interface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/simple-closure.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/slur.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/spaceable-grob.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/spacing-basic.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/spacing-determine-loose-columns.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/spacing-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/spanner.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M lily/spanner-scheme.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/stem.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M lily/stem-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/stream-event.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M lily/stream-event-scheme.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M lily/tempo-performer.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/tie.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/timing-translator.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M lily/translator-group.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/tuplet-bracket.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/unfolded-repeat-iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/unpure-pure-container.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/vertical-align-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/volta-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
dak
9 years, 7 months ago (2014-09-29 20:10:03 UTC) #1
A few oversights regarding unsmob->is_smob
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b