Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1616)

Issue 148230043: Replace mark_smob static member functions with non-static members (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Replace mark_smob static member functions with non-static members Since the mark functions generally need to access a number of members, it is quite more convenient if the mark functions are proper non-static member functions. Also contains commit: Don't use ASSERT_LIVE_IS_ALLOWED in simple smobs When replacing mark_smob with a proper member function, use of ASSERT_LIVE_IS_ALLOWED would require access to self_scm () or similar, and simple smobs don't link back to their SCM cell. This only concerns Skyline and Context_mod, so the loss is not all that large.

Patch Set 1 #

Patch Set 2 : Use Super::mark_trampoline for mark function to allow overriding #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -231 lines) Patch
M lily/book.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M lily/context.cc View 1 chunk +15 lines, -17 lines 0 comments Download
M lily/context-def.cc View 1 chunk +13 lines, -15 lines 0 comments Download
M lily/context-mod.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M lily/context-property.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M lily/dispatcher.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M lily/font-metric.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M lily/grob-array.cc View 1 chunk +1 line, -3 lines 0 comments Download
M lily/grob-smob.cc View 2 chunks +9 lines, -10 lines 0 comments Download
M lily/include/book.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/context.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/context-def.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/context-mod.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/dispatcher.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/font-metric.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/grob.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/grob-array.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/input.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/lily-lexer.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/lily-parser.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/listener.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/music-function.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/music-iterator.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/music-output.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/output-def.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/page-marker.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/paper-book.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/paper-outputter.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/pitch.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/prob.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/scheme-listener.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/scm-hash.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/score.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/skyline.hh View 1 chunk +0 lines, -1 line 0 comments Download
M lily/include/small-smobs.hh View 3 chunks +7 lines, -7 lines 0 comments Download
M lily/include/smobs.hh View 1 chunk +3 lines, -1 line 0 comments Download
M lily/include/smobs.tcc View 1 3 chunks +17 lines, -2 lines 0 comments Download
M lily/include/source-file.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/stencil.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/translator.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/translator-group.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/input-smob.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M lily/lily-lexer.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M lily/lily-parser.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M lily/listener.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M lily/music-function.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/music-iterator.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M lily/music-output.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M lily/output-def.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M lily/page-marker.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M lily/paper-book.cc View 1 chunk +12 lines, -13 lines 0 comments Download
M lily/paper-outputter.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M lily/pitch.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/prob.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M lily/scheme-listener.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M lily/scm-hash.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M lily/score.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M lily/skyline.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M lily/source-file.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M lily/stencil.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M lily/translator.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M lily/translator-group.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M lily/undead.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1
dak
9 years, 7 months ago (2014-09-27 14:32:01 UTC) #1
Use Super::mark_trampoline for mark function to allow overriding
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b