Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1997)

Issue 14807043: format-metronome-mark and metronome-markup don't support styles other than default (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by thomasmorley651
Modified:
10 years, 6 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

format-metronome-mark and metronome-markup don't support styles other than default issue 3096 - introducing 'styled-metronome-markup' with the possibility to set different styles for note-head and flag. Also, and currently quite theoretical, it is now possible to use another font here. For now the font-argument is used only to make \override MetronomeMark #'font-name = ... possible. - predefining several formatter and providing the possibility to let them customize by the user. - adding a regtest for different 'metronomeMarkFormatter'. - Limitation: There is still need to specify, what note-head/flag-style should be taken.

Patch Set 1 #

Patch Set 2 : adds flag-style to grob-properties for use by MetronomeMark #

Patch Set 3 : Adds 'flag-style to text-interface.cc and MetronomeMark-properties in define-grobs.scm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -18 lines) Patch
A input/regression/metronome-mark-formatter.ly View 1 1 chunk +108 lines, -0 lines 0 comments Download
M lily/text-interface.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scm/translation-functions.scm View 1 1 chunk +38 lines, -18 lines 0 comments Download

Messages

Total messages: 5
thomasmorley651
Please review.
10 years, 6 months ago (2013-10-17 21:24:52 UTC) #1
dak
The interface looks cumbersome to use. Why don't you just take the styles that are ...
10 years, 6 months ago (2013-10-17 21:29:04 UTC) #2
thomasmorley651
On 2013/10/17 21:29:04, dak wrote: > The interface looks cumbersome to use. Why don't you ...
10 years, 6 months ago (2013-10-17 21:54:20 UTC) #3
thomasmorley651
adds flag-style to grob-properties for use by MetronomeMark
10 years, 6 months ago (2013-10-21 23:52:40 UTC) #4
thomasmorley651
10 years, 6 months ago (2013-10-22 22:20:13 UTC) #5
Adds 'flag-style to text-interface.cc and MetronomeMark-properties in
define-grobs.scm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b