Issue 1473043: Moved windows-only targets into OS==win conditional.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1473043: Moved windows-only targets into OS==win conditional. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years ago by Alok Priyadarshi

Modified:
16 years ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Moved windows-only targets into OS==win conditional.

Patch Set 1 #

Created: 16 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+205 lines, -191 lines)			Patch
	M	samples/build_samples.gyp	View		1 chunk	+116 lines, -110 lines	0 comments	Download
	M	src/build_angle.gyp	View		3 chunks	+89 lines, -81 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kbr1

LGTM Did you mean to remove the messages about executing flex / bison?

16 years ago (2010-06-02 22:07:30 UTC) #2

Alok Priyadarshi

On 2010/06/02 22:07:30, kbr1 wrote: > LGTM > > Did you mean to remove the ...

16 years ago (2010-06-02 22:12:24 UTC) #3

kbr1

16 years ago (2010-06-02 22:15:50 UTC) #4

On 2010/06/02 22:12:24, alokp wrote:
> On 2010/06/02 22:07:30, kbr1 wrote:
> > LGTM
> > 
> > Did you mean to remove the messages about executing flex / bison?
> 
> Actually I added them. You need to take the rest of the day off.

Oops. I'm getting sloppy...

Expand All Messages | Collapse All Messages