Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1602)

Issue 14667043: Revert "Issue 3205: opening bar check causes crash if \score contains the \midi block" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by dak
Modified:
10 years, 5 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Revert "Issue 3205: opening bar check causes crash if \score contains the \midi block" This reverts commit c83a3afbc51c62769cbb8963371d37b312bbcd42. The replacement of Simple_music_iterator with Music_iterator in lily/bar-check-iterator.cc made bar checks at the start of music expressions inoperative altogether, even when not at a bar boundary: { a a { | } a a } stopped producing a diagnostic. Issue 3205 instead needs to be fixed together with issue 2392 which apparently may be called "Segfault in Midi when Simple_music_iterator is used at the beginning of an implicitly created context".

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lily/bar-check-iterator.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b