Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(184)

Issue 14655046: Issue 3618: Optional pitch/duration arguments don't work in longer argument lists. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by dak
Modified:
10 years, 2 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3618: Optional pitch/duration arguments don't work in longer argument lists. Contains commits (reverse order, last one will disappear after countdown/rebase): Issue 3618/3: Eliminate EXPECT_DURATION token in parser Issue 3618/2: Parser: replace is_duration with more versatile make_duration function Issue 3618/1: Eliminate EXPECT_PITCH token in parser Stop parser from grabbing more than one \default per occasion Issue 3611: Parser: remove non-closed expressions from function_arglist_nonbackup_common

Patch Set 1 #

Patch Set 2 : Removed \default-changing patch: broke valid code #

Patch Set 3 : Big rewrite and commenting #

Patch Set 4 : EG updates #

Patch Set 5 : Rebase on current master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -213 lines) Patch
M Documentation/extending/programming-interface.itely View 1 2 3 4 chunks +17 lines, -20 lines 0 comments Download
M lily/lexer.ll View 1 chunk +1 line, -5 lines 0 comments Download
M lily/parser.yy View 1 2 3 4 34 chunks +293 lines, -188 lines 0 comments Download

Messages

Total messages: 4
dak
Removed \default-changing patch: broke valid code
10 years, 6 months ago (2013-10-17 11:43:51 UTC) #1
dak
Big rewrite and commenting
10 years, 6 months ago (2013-10-17 19:10:00 UTC) #2
dak
EG updates
10 years, 6 months ago (2013-10-18 09:48:11 UTC) #3
dak
10 years, 6 months ago (2013-10-19 15:02:49 UTC) #4
Rebase on current master
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b