Issue 14633043: Document how completion engravers split scaled notes; issue 3560

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14633043: Document how completion engravers split scaled notes; issue 3560

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Keith

Modified:
10 years, 6 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Document how completion engravers split scaled notes; issue 3560 Also make the behavior changeable.

Patch Set 2 : extend regression tests #

Patch Set 3 : patchset without regtest changes #

Total comments: 2

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -25 lines)			Patch
M	Documentation/notation/rhythms.itely	View	2 chunks	+38 lines, -7 lines	1 comment	Download
M	lily/completion-note-heads-engraver.cc	View	3 chunks	+11 lines, -9 lines	1 comment	Download
M	lily/completion-rest-engraver.cc	View	3 chunks	+11 lines, -9 lines	0 comments	Download
M	scm/define-context-properties.scm	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Keith

https://codereview.appspot.com/14633043/diff/2/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/14633043/diff/2/Documentation/notation/rhythms.itely#newcode1889 Documentation/notation/rhythms.itely:1889: the treatment of shorter scaled durations, but is surpising ...

10 years, 6 months ago (2013-10-13 04:21:03 UTC) #1

dak

10 years, 6 months ago (2013-10-25 08:25:48 UTC) #2

https://codereview.appspot.com/14633043/diff/2/lily/completion-note-heads-eng...
File lily/completion-note-heads-engraver.cc (right):

https://codereview.appspot.com/14633043/diff/2/lily/completion-note-heads-eng...
lily/completion-note-heads-engraver.cc:202: if (left_to_do_ > longest_scaled ->
main_part_ )
Actually, moving the factor decision here is the smart thing to do.

Expand All Messages | Collapse All Messages