Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(417)

Issue 1461041: Removed the dependency of compiler on common. This is done to make compiler s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by Alok Priyadarshi
Modified:
13 years, 11 months ago
Reviewers:
kbr1, dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Removed the dependency of compiler on common. This is done to make compiler self-sufficient so that it is easier to consume by external developers. I tried to replace all instances of assert by simply redefining assert(x) to ASSERT(x), but was getting a lot of compile errors. I still need to investigate that.

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -18 lines) Patch
M src/build_angle.gyp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/OutputGLSL.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/OutputHLSL.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/Types.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/UnfoldSelect.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
A src/compiler/debug.h View 1 chunk +53 lines, -0 lines 0 comments Download
A src/compiler/debug.cpp View 1 chunk +35 lines, -0 lines 0 comments Download
M src/compiler/osinclude.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/preprocessor/atom.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/preprocessor/symbols.c View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/preprocessor/tokens.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/translator_common.vcproj View 2 chunks +8 lines, -0 lines 0 comments Download
M src/libGLESv2/Shader.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6
Alok Priyadarshi
13 years, 11 months ago (2010-06-01 23:20:58 UTC) #1
kbr1
LGTM Is there any convention in the ANGLE project about capitalization of file names?
13 years, 11 months ago (2010-06-01 23:45:50 UTC) #2
Alok Priyadarshi
File names are capitalized only if they define a class. The compiler project has a ...
13 years, 11 months ago (2010-06-02 00:14:59 UTC) #3
dgkoch
I believe compiler/UnfoldSelect.cpp has an extraneous #include "common/debug.h" which should be removed as well. Looks ...
13 years, 11 months ago (2010-06-02 14:22:33 UTC) #4
Alok Priyadarshi
Done. I also fixed a few compiler warnings about duplicated ASSERT definitions. Shader.cpp was unnecessarily ...
13 years, 11 months ago (2010-06-02 15:49:48 UTC) #5
dgkoch
13 years, 11 months ago (2010-06-02 15:55:23 UTC) #6
looks good here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b