Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 144280044: Store music list and markup command argument list names in docstring (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Store music list and markup command argument list names in docstring For one thing, the doc string does not make a lot of sense without the argument list and it cannot reliably be deduced from the doc string itself. For another, GUILEv2 does not do us the favor of storing the original argument list anywhere where it could be retrieved with a useful amount of labor. While it would be nice to put the types of the arguments into the doc string as well, the signature's actual predicates are only evaluated after macro expansion and that is too late for generating the doc string. So we just stick the argument list (after uncurrying) as a line at the top.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M scm/document-identifiers.scm View 2 chunks +7 lines, -5 lines 0 comments Download
M scm/document-markup.scm View 1 chunk +8 lines, -7 lines 0 comments Download
M scm/markup-macros.scm View 2 chunks +10 lines, -10 lines 0 comments Download
M scm/music-functions.scm View 1 chunk +3 lines, -3 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b