Issue 14424044: Remove DynamicText from script-interface

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14424044: Remove DynamicText from script-interface

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by dak

Modified:
10 years, 6 months ago

Reviewers:
mike7

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Remove DynamicText from script-interface Also gets the event-cause direction via a grob callback, allowing DynamicText.direction to be overriden if desired.

Patch Set 1 #

Patch Set 2 : Not that I have a clue what I am doing here... #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -11 lines)			Patch
M	lily/dynamic-align-engraver.cc	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	scm/define-grob-interfaces.scm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	scm/define-grobs.scm	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mike7

10 years, 6 months ago (2013-10-21 17:19:21 UTC) #2

Make sure to acknowledge dynamic text in slur-proto-engraver.cc and
tuplet-engraver.cc.

Expand All Messages | Collapse All Messages