Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1710)

Issue 144072: SSE2 optimizations for 32bit blending blitters

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by Stephen White
Modified:
15 years, 1 month ago
Reviewers:
reed
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL implements SSE2 optimizations for 3 of the 32bit blending blitters. It uses CPUID to detect for SSE2 at runtime. In order to accomodate runtime detection, it changes the platform procs from static arrays to static functions. It also includes an implementation of SkTime_Unix for Win32 (the file should probably be renamed).

Patch Set 1 #

Total comments: 8

Patch Set 2 : Responding to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -46 lines) Patch
include/core/SkBlitRow.h View 1 1 chunk +10 lines, -7 lines 0 comments Download
src/core/SkBlitRow_D16.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
src/core/SkBlitRow_D32.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
src/opts/SkBlitRow_opts_SSE2.cpp View 1 1 chunk +336 lines, -0 lines 0 comments Download
src/opts/SkBlitRow_opts_arm.cpp View 1 3 chunks +14 lines, -3 lines 0 comments Download
src/opts/SkBlitRow_opts_none.cpp View 1 1 chunk +9 lines, -33 lines 0 comments Download
src/ports/SkTime_win.cpp View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Stephen White
15 years, 1 month ago (2009-10-31 20:17:29 UTC) #1
reed
LGMT, module some minor comments http://codereview.appspot.com/144072/diff/1/2 File include/config/SkUserConfig.h (right): http://codereview.appspot.com/144072/diff/1/2#newcode128 Line 128: /* The SK_SSE2 ...
15 years, 1 month ago (2009-11-04 18:47:08 UTC) #2
reed
http://codereview.appspot.com/144072/diff/1/4 File src/opts/SkBlitRow_opts_SSE2.cpp (right): http://codereview.appspot.com/144072/diff/1/4#newcode21 Line 21: Do we still need this flag/test?
15 years, 1 month ago (2009-11-04 18:47:57 UTC) #3
Stephen White
http://codereview.appspot.com/144072/diff/1/2 File include/config/SkUserConfig.h (right): http://codereview.appspot.com/144072/diff/1/2#newcode128 Line 128: /* The SK_SSE2 flag enables compile-time support for ...
15 years, 1 month ago (2009-11-04 19:19:07 UTC) #4
Stephen White
Responding to comments
15 years, 1 month ago (2009-11-04 19:28:44 UTC) #5
reed
15 years, 1 month ago (2009-11-04 20:35:02 UTC) #6
On 2009/11/04 19:28:44, Stephen White wrote:
> Responding to comments

LGTM - awesome to get the SSE2 code in, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b