Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(183)

Issue 144049: New twoside mode.

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by xmichael-k
Modified:
14 years, 4 months ago
Reviewers:
joeneeman, Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

New twoside mode. * This patch allows to specify different margins for odd and even pages by setting twoside to true in the \paper block * The corresponding settings are inner- and outer-margin, there exists the possibility to set a binding-offset, too * These values are stored internally as left- and right-margin, though. Translation is done in page.scm:make-page-stencil * Small code cleanup in paper.scm:set-paper-dimensions

Patch Set 1 #

Total comments: 6

Patch Set 2 : Revised version. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -52 lines) Patch
A input/regression/paper-twosided.ly View 1 chunk +19 lines, -0 lines 0 comments Download
A input/regression/paper-twosided-bcorr.ly View 1 chunk +20 lines, -0 lines 0 comments Download
M lily/output-def.cc View 1 5 chunks +22 lines, -7 lines 0 comments Download
M ly/paper-defaults-init.ly View 1 2 chunks +5 lines, -0 lines 0 comments Download
M scm/page.scm View 1 15 chunks +32 lines, -23 lines 1 comment Download
M scm/paper.scm View 1 3 chunks +25 lines, -22 lines 1 comment Download

Messages

Total messages: 3
Neil Puttock
LGTM. http://codereview.appspot.com/144049/diff/1/2 File input/regression/paper-twoside.ly (right): http://codereview.appspot.com/144049/diff/1/2#newcode15 Line 15: binding-offset = 5 \mm I think this ...
14 years, 5 months ago (2009-10-30 22:19:50 UTC) #1
joeneeman
http://codereview.appspot.com/144049/diff/1/4 File ly/paper-defaults-init.ly (right): http://codereview.appspot.com/144049/diff/1/4#newcode90 Line 90: twoside = ##f On 2009/10/30 22:19:50, Neil Puttock ...
14 years, 5 months ago (2009-10-31 06:56:38 UTC) #2
Neil Puttock
14 years, 4 months ago (2009-11-04 17:55:10 UTC) #3
Hi Michael,

This looks OK, apart from a few indentation issues.  In particular, the whole of
`set-paper-dimensions' is slightly off.

Cheers,
Neil

http://codereview.appspot.com/144049/diff/23/1010
File scm/page.scm (right):

http://codereview.appspot.com/144049/diff/23/1010#newcode316
Line 316: (set! page-stencil
indentation

http://codereview.appspot.com/144049/diff/23/1011
File scm/paper.scm (right):

http://codereview.appspot.com/144049/diff/23/1011#newcode236
Line 236: (("inner-margin" . ,w) . preserve)
hard tabs (inconsistent with rest of indentation)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b