Rocketfuel topology dataset support for topology reader

The patch aims for the support of rocketfuel topology dataset in TopologyReader.  It supports to read the file in order to create Node and NetDevice (p2plink in example script).

*Rocketfuel project: http://www.cs.washington.edu/research/networking/rocketfuel/

This patch is against for revision 6326 of ns-3-dev.

Comments are welcome.

[Hajime Tazaki, 2010-06-02 02:08:06]

This patchset includes Rocketfuel topology dataset reader.

regards,
hajime

[Josh Pelkey, 2010-06-16 17:17:11]

This addition to the existing topology reader looks good (assuming it works, I
didn't actually run it and check :).  I support merging this for ns-3.9.  A few
small comments below.

http://codereview.appspot.com/1432042/diff/1/4
File src/contrib/topology-read/rocketfuel-topology-reader.cc (right):

http://codereview.appspot.com/1432042/diff/1/4#newcode30
src/contrib/topology-read/rocketfuel-topology-reader.cc:30: using namespace std;
usually don't see this in ns-3, though that doesn't seem to be a hard rule

http://codereview.appspot.com/1432042/diff/1/4#newcode286
src/contrib/topology-read/rocketfuel-topology-reader.cc:286: goto next;
goto! haven't seen that in a while.  could you rearrange to avoid this?

http://codereview.appspot.com/1432042/diff/1/4#newcode293
src/contrib/topology-read/rocketfuel-topology-reader.cc:293: goto next;
same

[Hajime Tazaki, 2010-06-17 05:12:14]

Thanks, Josh.
I've updated the patchset (Patch Set 2).

Comments are inline.

On 2010/06/16 17:17:11, Josh Pelkey wrote:
> This addition to the existing topology reader looks good (assuming it works, I
> didn't actually run it and check :).  I support merging this for ns-3.9.  A
few
> small comments below.
> 
> http://codereview.appspot.com/1432042/diff/1/4
> File src/contrib/topology-read/rocketfuel-topology-reader.cc (right):
> 
> http://codereview.appspot.com/1432042/diff/1/4#newcode30
> src/contrib/topology-read/rocketfuel-topology-reader.cc:30: using namespace
std;
> usually don't see this in ns-3, though that doesn't seem to be a hard rule

I modified not to use this declaration.

> http://codereview.appspot.com/1432042/diff/1/4#newcode286
> src/contrib/topology-read/rocketfuel-topology-reader.cc:286: goto next;
> goto! haven't seen that in a while.  could you rearrange to avoid this?
> 
> http://codereview.appspot.com/1432042/diff/1/4#newcode293
> src/contrib/topology-read/rocketfuel-topology-reader.cc:293: goto next;
> same

I don't remember I used goto :-), but modified without this.

[Josh Pelkey, 2010-06-17 15:48:44]

Thanks Hajime.  The only other thing I thought about was maybe renaming the
sample topology text file to better align with the Inet and Orbis stuff that is
already there.  Or, if you don't like changing the name, maybe reorganizing the
directory to include a folder for data sets and subfolders for rocket-fuel,
Inet, and Orbis.  I'm just concerned that the topology-read examples directory
might start to get a bit jumbled if more readers and more data sets get added in
the future.

[Hajime Tazaki, 2010-06-18 03:03:25]

Thanks Josh.

I've changed the name of sample topology file as you suggested.
See the patch set 3 that would be candidate for the merge.

I have received another comment (personally) from others. After handling these
comments, I'm ready to push it.

[Josh Pelkey, 2010-06-21 13:18:44]

Hajime,

Go ahead and push to ns-3-dev when you are ready.

Thanks!


On 2010/06/18 03:03:25, Hajime Tazaki wrote:
> Thanks Josh.
> 
> I've changed the name of sample topology file as you suggested.
> See the patch set 3 that would be candidate for the merge.
> 
> I have received another comment (personally) from others. After handling these
> comments, I'm ready to push it.

[Hajime Tazaki, 2010-06-23 10:25:27]

I've pushed these patchset to ns-3-dev.