Issue 143071: Start work on adding annotations for horizontal paper variables.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 143071: Start work on adding annotations for horizontal paper variables.

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by Neil Puttock

Modified:
9 years, 7 months ago

Reviewers:
xmichael-k

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Start work on adding annotations for horizontal paper variables.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Revise annotate? predicate #

Patch Set 3 : Rebase. #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -82 lines)			Patch
M	scm/page.scm	View	1 2	5 chunks	+118 lines, -35 lines	0 comments	Download
M	scm/paper-system.scm	View	1 2	2 chunks	+11 lines, -9 lines	0 comments	Download
M	scm/stencil.scm	View	1 2	7 chunks	+46 lines, -38 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

xmichael-k

Nice work, very helpful! Don't worry if my comments are stupid... ;)) http://codereview.appspot.com/143071/diff/1/2 File scm/page.scm ...

14 years, 5 months ago (2009-11-02 08:01:38 UTC) #1

Neil Puttock

14 years, 5 months ago (2009-11-04 21:58:54 UTC) #2

On 2009/11/02 08:01:38, xmichael-k wrote:
> Nice work, very helpful!

Cheers.

> Don't worry if my comments are stupid... ;))

No, they're very useful.

> 
> http://codereview.appspot.com/143071/diff/1/2
> File scm/page.scm (right):
> 
> http://codereview.appspot.com/143071/diff/1/2#newcode38
> Line 38: (define (annotate-x? layout)
> What about 
> (define (annotate? layout . dir)
>   (eq? #t (case dir
>             (('X) (ly:output-def-lookup layout 'annotate-x-spacing))
>             (('Y) (ly:output-def-lookup layout 'annotate-y-spacing))
>             (('()) (or (annotate? layout X) (annotate? layout Y)))
>             (else #f)))

I can't get this to work, unfortunately.  The rest argument will be a list, and
`case' doesn't want to match '(X) or '(Y).

> 
> http://codereview.appspot.com/143071/diff/1/2#newcode126
> Line 126: (add-x-stencil (lambda (x)
> Again, this seems to me a little redundant. Maybe one add-stencil procedure
> would do it?

OK, I'll combine the two procs and add an axis arg.

> 
> http://codereview.appspot.com/143071/diff/1/2#newcode134
> Line 134: (if (annotate-y? layout)
> I would prefer to put the items to annotate in an alist and do a (for-each)

That would be more elegant. :)

Thanks,
Neil

Expand All Messages | Collapse All Messages