Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1218)

Issue 1428042: Experimental support for woff fonts in svg. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by janneke
Modified:
12 years, 9 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Experimental support for woff fonts in svg. Use out/bin/lilypond -d backend=svg example-1.ly out/bin/lilypond -d backend=svg -d svg-woff --output=woff example-1.ly cp example-1.svg woff.svg mf/out/emmentaler-20.woff /var/www/woff and use firefox 3.6 or later to browse http://localhost/woff (chromium-browser 5.0.342.9~r43360-0ubuntu2 does not yet work for me). Or see the current results at http://lilypond.org/people/janneke/woff/

Patch Set 1 #

Patch Set 2 : make css font list dynamic #

Total comments: 2

Patch Set 3 : Process Han-Wen's comments #

Patch Set 4 : also extract and define pango-fonts from paper - fixes dynamics, fingering etc #

Patch Set 5 : use versioned font src urls. Allows font changes/updates. #

Total comments: 2

Patch Set 6 : Process comments: move scm functions, revert ff 2009-bump. #

Patch Set 7 : fix crash with empty pango-physical-fonts. Thanks Neil! #

Total comments: 6

Patch Set 8 : Plug memory leak. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -48 lines) Patch
M Documentation/changes.tely View 6 1 chunk +5 lines, -0 lines 0 comments Download
M GNUmakefile.in View 1 chunk +2 lines, -0 lines 0 comments Download
M configure.in View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M lily/include/paper-outputter.hh View 1 chunk +6 lines, -4 lines 0 comments Download
M lily/paper-outputter.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M lily/paper-outputter-scheme.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M mf/GNUmakefile View 6 chunks +13 lines, -8 lines 0 comments Download
M mf/emmentaler-brace.pe.in View 1 chunk +1 line, -0 lines 0 comments Download
M scm/backend-library.scm View 6 1 chunk +64 lines, -0 lines 0 comments Download
M scm/framework-ps.scm View 2 3 2 chunks +9 lines, -31 lines 0 comments Download
M scm/framework-svg.scm View 1 2 3 4 5 6 7 3 chunks +67 lines, -0 lines 0 comments Download
M scm/lily.scm View 1 chunk +4 lines, -1 line 0 comments Download
M scm/output-lib.scm View 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M scm/output-svg.scm View 1 2 3 5 chunks +69 lines, -4 lines 0 comments Download
M scripts/build/gen-emmentaler-scripts.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27
hanwenn
can you add some doc in the commit description what WOFF fonts are ? A ...
13 years, 10 months ago (2010-05-31 20:49:26 UTC) #1
janneke
On 2010/05/31 20:49:26, hanwenn wrote: > can you add some doc in the commit description ...
13 years, 10 months ago (2010-05-31 21:30:16 UTC) #2
hanwenn
On Mon, May 31, 2010 at 6:30 PM, <jan.nieuwenhuizen@gmail.com> wrote: > Description: > Experimental support ...
13 years, 10 months ago (2010-05-31 21:40:47 UTC) #3
Neil Puttock
http://codereview.appspot.com/1428042/diff/13002/17023 File scm/output-lib.scm (right): http://codereview.appspot.com/1428042/diff/13002/17023#newcode897 scm/output-lib.scm:897: (define-public (font-name-split font-name) These look out of place here. ...
13 years, 9 months ago (2010-06-06 14:40:48 UTC) #4
Patrick McCarty
http://codereview.appspot.com/1428042/diff/13002/17014 File configure.in (right): http://codereview.appspot.com/1428042/diff/13002/17014#newcode140 configure.in:140: STEPMAKE_PATH_PROG(FONTFORGE, fontforge, REQUIRED, 20090923) Is 20090923 actually required? I ...
13 years, 9 months ago (2010-06-06 18:42:05 UTC) #5
Graham Percival
On Sun, Jun 06, 2010 at 06:42:05PM +0000, pnorcks@gmail.com wrote: > > http://codereview.appspot.com/1428042/diff/13002/17014#newcode140 > configure.in:140: ...
13 years, 9 months ago (2010-06-06 20:33:13 UTC) #6
james.lowe_datacore.com
Graham, On 6 Jun 2010, at 21:33, Graham Percival wrote: > On Sun, Jun 06, ...
13 years, 9 months ago (2010-06-06 20:42:02 UTC) #7
janneke
> Move to font.scm or backend-library.scm? Moved to backend-library.scm. I mistook output-lib to be the ...
13 years, 9 months ago (2010-06-07 08:05:04 UTC) #8
janneke
On 2010/06/06 18:42:05, Patrick McCarty wrote: > http://codereview.appspot.com/1428042/diff/13002/17014 > File configure.in (right): > > http://codereview.appspot.com/1428042/diff/13002/17014#newcode140 ...
13 years, 9 months ago (2010-06-07 08:08:53 UTC) #9
Neil Puttock
Hi Jan, I've just been testing this patch, and have stumbled upon a problem with ...
13 years, 9 months ago (2010-06-07 16:44:12 UTC) #10
janneke-list_xs4all.nl
Op maandag 07-06-2010 om 16:44 uur [tijdzone +0000], schreef n.puttock@gmail.com: Hi Neil, > I've just ...
13 years, 9 months ago (2010-06-09 21:58:13 UTC) #11
Neil Puttock
Hi Jan, On 2010/06/09 21:58:13, janneke-list_xs4all.nl wrote: > Thanks for looking into this! I've added ...
13 years, 9 months ago (2010-06-14 20:09:41 UTC) #12
janneke
On 2010/06/14 20:09:41, Neil Puttock wrote: Hi Neil, I just rebased the patch onto latest ...
13 years, 9 months ago (2010-06-15 08:55:49 UTC) #13
Neil Puttock
Hi Jan, On 2010/06/15 08:55:49, jan.nieuwenhuizen wrote: > I just rebased the patch onto latest ...
13 years, 9 months ago (2010-06-16 22:02:43 UTC) #14
Patrick McCarty
http://codereview.appspot.com/1428042/diff/34001/35011 File scm/framework-svg.scm (right): http://codereview.appspot.com/1428042/diff/34001/35011#newcode138 scm/framework-svg.scm:138: (dump (svg-end)) Adding the following code fixes the memory ...
13 years, 9 months ago (2010-06-17 19:49:26 UTC) #15
Neil Puttock
On 2010/06/17 19:49:26, Patrick McCarty wrote: > Adding the following code fixes the memory leak ...
13 years, 9 months ago (2010-06-17 20:04:53 UTC) #16
Patrick McCarty
Just a few more comments... http://codereview.appspot.com/1428042/diff/34001/35014 File scm/output-svg.scm (right): http://codereview.appspot.com/1428042/diff/34001/35014#newcode25 scm/output-svg.scm:25: ;;; set by framework-gnome.scm ...
13 years, 9 months ago (2010-06-17 20:07:23 UTC) #17
Patrick McCarty
On 2010/06/17 20:04:53, Neil Puttock wrote: > On 2010/06/17 19:49:26, Patrick McCarty wrote: > > ...
13 years, 9 months ago (2010-06-17 20:11:02 UTC) #18
janneke
> Do you compile with --disable-optimising? Yes. > I've done a few more tests, and ...
13 years, 9 months ago (2010-06-18 11:29:23 UTC) #19
janneke
On 2010/06/17 20:07:23, Patrick McCarty wrote: > I also think we should stay away from ...
13 years, 9 months ago (2010-06-18 11:31:51 UTC) #20
Graham Percival
On Fri, Jun 18, 2010 at 12:29 PM, <jan.nieuwenhuizen@gmail.com> wrote: > >> If I run ...
13 years, 9 months ago (2010-06-18 11:47:12 UTC) #21
Neil Puttock
On 2010/06/18 11:29:23, jan.nieuwenhuizen wrote: > I'll go ahead and test on a 32 bit ...
13 years, 9 months ago (2010-06-18 17:32:51 UTC) #22
janneke
> I'm using a 64 bit machine (Ubuntu 10.04). Me too. Fresh doc build succeeds? ...
13 years, 9 months ago (2010-06-22 19:09:43 UTC) #23
Neil Puttock
On 2010/06/22 19:09:43, jan.nieuwenhuizen wrote: > You still have a problem with this, is your ...
13 years, 9 months ago (2010-06-22 21:06:16 UTC) #24
Neil Puttock
On 2010/06/22 21:06:16, Neil Puttock wrote: > I'm just starting a completely clean build. Will ...
13 years, 9 months ago (2010-06-22 23:06:02 UTC) #25
janneke-list_xs4all.nl
Op dinsdag 22-06-2010 om 23:06 uur [tijdzone +0000], schreef n.puttock@gmail.com: > The clean build completed ...
13 years, 9 months ago (2010-06-23 07:03:42 UTC) #26
Colin Campbell
12 years, 9 months ago (2011-06-27 01:31:30 UTC) #27
Should this issue be closed, per the changes list announcing it in 2.14?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b