Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6336)

Issue 142720043: Issue 4096: \addlyrics always creates its own Voice context (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4096: \addlyrics always creates its own Voice context Contains commits: Give \addlyrics the power of christening the associated context With \new Voice \with { \stemDown } { c1 } \addlyrics { Oh } as opposed to \new Voice = "upper" \with { \stemDown } { c1 } \addlyrics { Oh } \addlyrics created its own context (consequently not using \stemDown) since it had no context name for the Lyrics context to attach to. In this case (namely being preceded by an unnamed new Voice context), it will now give a name to the context itself. Fix bugs preventing \addlyrics from finding an existing context to attach to Refactor grammar to give \addlyrics a good target to attach to So far, \new Staff \new Voice { c1 } \addlyrics { Oh } \addlyrics { Ah } was factored as \new Staff \new Voice { { c1 } \addlyrics { Oh } \addlyrics { Ah } } which resulted in something like \new Staff \new Voice << \context Voice = "uniqueContext0" { c1 } \new Lyrics \lyricsto "uniqueContext0" { Oh } \new Lyrics \lyricsto "uniqueContext0" { Ah } >> This made it impossible to work with the likes of \new Staff \new Voice \with { \stemUp } { c1 } \addlyrics ... since the voice the lyrics attached to was always a new voice. Fixing the grouping in the grammar is a first required step for getting this under control. Refactor grammar, folding re_rhythmed_music into composite_music Refactor grammar, folding complex_music into composite_music

Patch Set 1 #

Patch Set 2 : Ugh #

Patch Set 3 : \new Staff ... \addlyrics -> \new Staff \new Voice ... \addlyrics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -63 lines) Patch
A input/regression/addlyrics-existing-context.ly View 1 1 chunk +25 lines, -0 lines 0 comments Download
M lily/parser.yy View 1 4 chunks +86 lines, -48 lines 0 comments Download
M scm/ly-syntax-constructors.scm View 1 2 2 chunks +30 lines, -15 lines 0 comments Download

Messages

Total messages: 2
dak
Ugh
9 years, 7 months ago (2014-09-08 13:53:32 UTC) #1
dak
9 years, 7 months ago (2014-09-08 15:26:50 UTC) #2
\new Staff ... \addlyrics -> \new Staff \new Voice ... \addlyrics
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b