Issue 141050: Fix CGIHTTPRequestHandler.run_cgi for py3k

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 141050: Fix CGIHTTPRequestHandler.run_cgi for py3k (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 6 months ago by drukker

Modified:
14 years, 5 months ago

Reviewers:

Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/

Visibility:
Public.

Description

This patch fixes http://bugs.python.org/issue1235 for py3k.

Patch Set 2 : Forgot to update comment; readded flush call #

Patch Set 3 : revert unify: Windows implementation necessarily inferior (socket.fileno cannot be used) #

Created: 14 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	Lib/http/server.py	View	1 2	1 chunk	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

drukker

http://codereview.appspot.com/141050/diff/1/2 File Lib/http/server.py (left): http://codereview.appspot.com/141050/diff/1/2#oldcode1046 Line 1046: self.wfile.flush() # Always flush before forking flush is ...

14 years, 6 months ago (2009-10-25 15:01:19 UTC) #1

drukker

http://codereview.appspot.com/141050/diff/1001/7 File Lib/http/server.py (left): http://codereview.appspot.com/141050/diff/1001/7#oldcode1046 Line 1046: self.wfile.flush() # Always flush before forking flush is ...

14 years, 6 months ago (2009-10-25 16:09:17 UTC) #2

drukker

Since you've worked on http://bugs.python.org/issue3133, I've put you in the reviewers list. Hope you don't ...

14 years, 6 months ago (2009-10-25 16:22:35 UTC) #3

drukker

14 years, 6 months ago (2009-10-26 09:39:51 UTC) #4

On 2009/10/25 15:01:19, drukker wrote:
> http://codereview.appspot.com/141050/diff/1/2
> File Lib/http/server.py (left):
> 
> http://codereview.appspot.com/141050/diff/1/2#oldcode1046
> Line 1046: self.wfile.flush() # Always flush before forking
> flush is done by subprocess module

actually, it isn't

Expand All Messages | Collapse All Messages