Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(447)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 14035043: Issue 3566: Grace notes should be autobeamed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by dak
Modified:
11 years, 5 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3566: Grace notes should be autobeamed This works by adding a Grace_auto_beam_engraver that considers an entire grace phrase as one autobeam group. Also contains commit: Add Grace_auto_beam_engraver to default engravers for Voice

Patch Set 1 #

Patch Set 2 : The real commit series will revert the sloppy temporary convert-ly rule again #

Patch Set 3 : Add regtest #

Patch Set 4 : Rebase on current master, rerunning convert-ly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -154 lines) Patch
M Documentation/cs/learning/common-notation.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/learning/common-notation.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/notation/rhythms.itely View 1 6 chunks +7 lines, -7 lines 0 comments Download
M Documentation/de/notation/simultaneous.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/notation/spacing.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/notation/vocal.itely View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/es/learning/common-notation.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/rhythms.itely View 1 6 chunks +7 lines, -7 lines 0 comments Download
M Documentation/es/notation/simultaneous.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/spacing.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/es/notation/vocal.itely View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/fr/learning/common-notation.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/rhythms.itely View 1 6 chunks +7 lines, -7 lines 0 comments Download
M Documentation/fr/notation/simultaneous.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/spacing.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/fr/notation/vocal.itely View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/hu/learning/common-notation.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/it/learning/common-notation.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/it/notation/rhythms.itely View 1 6 chunks +7 lines, -7 lines 0 comments Download
M Documentation/it/notation/simultaneous.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/learning/common-notation.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/rhythms.itely View 1 6 chunks +7 lines, -7 lines 0 comments Download
M Documentation/ja/notation/simultaneous.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/spacing.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/vocal.itely View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/learning/common-notation.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/nl/learning/common-notation.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/rhythms.itely View 1 7 chunks +8 lines, -7 lines 0 comments Download
M Documentation/notation/simultaneous.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/spacing.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/notation/vocal.itely View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/snippets/positioning-grace-notes-with-floating-space.ly View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/proportional-strict-notespacing.ly View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/text-headword.ly View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/tweaking-grace-layout-within-music.ly View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/beam-beamlet-grace.ly View 1 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/beam-collision-grace.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/grace.ly View 1 2 chunks +5 lines, -5 lines 0 comments Download
A input/regression/grace-auto-beam-engraver.ly View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M input/regression/grace-bar-line.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/grace-beam.ly View 1 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/grace-end.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/grace-start.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/grace-stem-length.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/grace-volta-repeat.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/lyric-extender-includegraces.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/lyrics-includegraces.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/slur-broken-trend.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/slur-scoring.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/spacing-grace.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/spacing-non-adjacent-columns3.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/spacing-strict-notespacing.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/trill-spanner-grace.ly View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lily/auto-beam-engraver.cc View 5 chunks +102 lines, -7 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +1 line, -0 lines 0 comments Download
M python/convertrules.py View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dak
The real commit series will revert the sloppy temporary convert-ly rule again
11 years, 6 months ago (2013-09-27 14:08:02 UTC) #1
dak
Add regtest
11 years, 6 months ago (2013-09-27 16:24:17 UTC) #2
dak
11 years, 6 months ago (2013-09-27 18:38:01 UTC) #3 
Rebase on current master, rerunning convert-ly
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b