Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3621)

Issue 140041: [PATCH] Free machine code when its Function is destroyed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by Jeffrey Yasskin
Modified:
14 years, 6 months ago
Reviewers:
CC:
llvm-commits_cs.uiuc.edu
Visibility:
Public.

Description

Patch at http://codereview.appspot.com/download/issue140041_1.diff Automatically do the equivalent of freeMachineCodeForFunction(F) when F is being destroyed. This allows users to run global optimizations like globaldce even after some functions have been jitted. This patch also removes the Function* parameter to JITEventListener::NotifyFreeingMachineCode() since it can cause that to be called when the Function is partially destroyed. This change will be even more helpful later when I think we'll want to allow machine code to actually outlive its Function.

Patch Set 1 #

Patch Set 2 : Merge with r84967. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -35 lines) Patch
M include/llvm/ExecutionEngine/ExecutionEngine.h View 1 chunk +2 lines, -3 lines 0 comments Download
M include/llvm/ExecutionEngine/JITEventListener.h View 1 chunk +5 lines, -2 lines 0 comments Download
M lib/ExecutionEngine/JIT/JIT.h View 1 chunk +1 line, -1 line 0 comments Download
M lib/ExecutionEngine/JIT/JIT.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/ExecutionEngine/JIT/JITEmitter.cpp View 1 6 chunks +32 lines, -13 lines 0 comments Download
M lib/ExecutionEngine/JIT/OProfileJITEventListener.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M unittests/ExecutionEngine/JIT/JITEventListenerTest.cpp View 7 chunks +2 lines, -9 lines 0 comments Download
M unittests/ExecutionEngine/JIT/JITTest.cpp View 1 5 chunks +160 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Jeffrey Yasskin
14 years, 6 months ago (2009-10-22 23:29:45 UTC) #1
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b