Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6402)

Issue 13858044: Replace unwarranted uses of map with for-each and other Scheme cleanups (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dak
Modified:
10 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Replace unwarranted uses of map with for-each and other Scheme cleanups Note that some uses of map actually relied on execution order (namely expecting map to behave like map-in-order) and thus were not just inelegant because of the side effect. There are also some other mostly trivial simplification of Scheme constructs.

Patch Set 1 #

Patch Set 2 : Indeed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -327 lines) Patch
M input/regression/music-map.ly View 1 chunk +4 lines, -9 lines 0 comments Download
M input/regression/tie-chord.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M ly/init.ly View 1 chunk +6 lines, -6 lines 0 comments Download
M scm/backend-library.scm View 4 chunks +12 lines, -14 lines 0 comments Download
M scm/bar-line.scm View 4 chunks +51 lines, -51 lines 0 comments Download
M scm/chord-generic-names.scm View 1 chunk +9 lines, -9 lines 0 comments Download
M scm/chord-ignatzek-names.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/define-grobs.scm View 1 chunk +5 lines, -5 lines 0 comments Download
M scm/define-markup-commands.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/define-music-types.scm View 1 chunk +2 lines, -2 lines 0 comments Download
M scm/define-note-names.scm View 1 chunk +8 lines, -7 lines 0 comments Download
M scm/define-stencil-commands.scm View 1 chunk +3 lines, -3 lines 0 comments Download
M scm/define-woodwind-diagrams.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/display-woodwind-diagrams.scm View 2 chunks +4 lines, -6 lines 0 comments Download
M scm/document-backend.scm View 3 chunks +12 lines, -12 lines 0 comments Download
M scm/document-context-mods.scm View 2 chunks +8 lines, -13 lines 0 comments Download
M scm/document-functions.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/document-identifiers.scm View 1 3 chunks +9 lines, -14 lines 0 comments Download
M scm/document-markup.scm View 3 chunks +11 lines, -11 lines 0 comments Download
M scm/document-music.scm View 1 chunk +11 lines, -12 lines 0 comments Download
M scm/document-translation.scm View 1 4 chunks +18 lines, -20 lines 0 comments Download
M scm/document-type-predicates.scm View 2 chunks +4 lines, -5 lines 0 comments Download
M scm/documentation-generate.scm View 1 chunk +10 lines, -10 lines 0 comments Download
M scm/documentation-lib.scm View 3 chunks +11 lines, -11 lines 0 comments Download
M scm/font.scm View 1 chunk +8 lines, -8 lines 0 comments Download
M scm/framework-ps.scm View 2 chunks +10 lines, -10 lines 0 comments Download
M scm/lily.scm View 1 2 chunks +9 lines, -11 lines 0 comments Download
M scm/lily-library.scm View 1 chunk +1 line, -4 lines 0 comments Download
M scm/modal-transforms.scm View 2 chunks +2 lines, -2 lines 0 comments Download
M scm/music-functions.scm View 4 chunks +11 lines, -11 lines 0 comments Download
M scm/output-lib.scm View 1 chunk +2 lines, -2 lines 0 comments Download
M scm/output-svg.scm View 3 chunks +11 lines, -11 lines 0 comments Download
M scm/page.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/parser-clef.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/part-combiner.scm View 2 chunks +4 lines, -4 lines 0 comments Download
M scm/ps-to-png.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/safe-lily.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/song-util.scm View 1 chunk +5 lines, -6 lines 0 comments Download
M scm/stencil.scm View 3 chunks +13 lines, -13 lines 0 comments Download
M scm/tablature.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/time-signature-settings.scm View 1 chunk +2 lines, -2 lines 0 comments Download
M scm/to-xml.scm View 3 chunks +3 lines, -4 lines 0 comments Download
M scm/translation-functions.scm View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 1
dak
10 years, 7 months ago (2013-09-24 15:54:37 UTC) #1
Indeed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b