Issue 13668047: Don't modify lists returned by markup list functions in interpret-markup-list

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13668047: Don't modify lists returned by markup list functions in interpret-markup-list (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by dak

Modified:
10 years, 6 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Don't modify lists returned by markup list functions in interpret-markup-list This requires either a) copying any list manually b) interpreting markup lists right-to-left c) more complicated and/or non-O(n) algorithms This patch chooses b). Modifying the lists is not really appropriate since the lists may be created by user-written markup commands and any problems resulting from not expecting modifications of the return value might be quite hard to debug.

Patch Set 1 #

Patch Set 2 : Don't count your parens until they are matched #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
	M	scm/markup.scm	View	1	1 chunk	+7 lines, -10 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Don't count your parens until they are matched

Expand All Messages | Collapse All Messages