Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(874)

Issue 136430043: This adds support for \addlyrics on arbitrary contexts including Staff (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

This adds support for \addlyrics on arbitrary contexts including Staff The regtest should illustrate why this can be an advantage. At the current point of time, behavior for melismata is deficient: a melisma is recognized when all subcontexts have a melisma. That means that, for example, << c''1 \\ { c'2( d') } >> counts as two syllables since in the middle of the measure there is only a melisma in one context. Proper treatment of melismata will require more work in the translators and/or additional support from iterators. The first upload represents the state of issue4096. The second upload contains the commits Derive melisma_busy state from child contexts when available Allow associatedVoice to be of different type than Voice Revert "Convert \new Staff ... \addlyrics into \new Staff \new Voice ... \addlyrics" This reverts commit 76f256075f0a4f481d7e11c19dd55ab09030fe5b. Allow \addlyrics to work with arbitrary contexts Add regtest for \addlyrics on Staff context

Patch Set 1 #

Patch Set 2 : Work on top of issue 4096 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -81 lines) Patch
A input/regression/addlyrics-existing-context.ly View 1 chunk +25 lines, -0 lines 0 comments Download
A input/regression/addlyrics-to-staff-context.ly View 1 1 chunk +22 lines, -0 lines 0 comments Download
M lily/context.cc View 1 1 chunk +20 lines, -5 lines 0 comments Download
M lily/lyric-combine-music-iterator.cc View 1 7 chunks +22 lines, -10 lines 0 comments Download
M lily/lyric-engraver.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M lily/parser.yy View 1 4 chunks +90 lines, -48 lines 0 comments Download
M ly/engraver-init.ly View 1 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-context-properties.scm View 1 1 chunk +4 lines, -1 line 0 comments Download
M scm/define-music-properties.scm View 1 1 chunk +3 lines, -1 line 0 comments Download
M scm/ly-syntax-constructors.scm View 1 3 chunks +22 lines, -14 lines 0 comments Download

Messages

Total messages: 1
dak
9 years, 7 months ago (2014-09-09 15:12:32 UTC) #1
Work on top of issue 4096
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b