Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(158)

Issue 1364041: Resolve non-cannoical file system names correctly (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 1 month ago by Jasvir
Modified:
16 years ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

PluginCompilerMain tested for equality of two directories based equality of their abstract pathnames. In this case: "./mootools" is not the same as "././mootools". This change cannoncalizes the pathnames before carrying out the comparison

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/com/google/caja/plugin/PluginCompilerMain.java View 1 chunk +3 lines, -0 lines 0 comments Download
M src/com/google/caja/plugin/UriToFile.java View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Jasvir
16 years, 1 month ago (2010-05-27 23:52:13 UTC) #1
metaweta
16 years, 1 month ago (2010-05-28 00:03:04 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b