Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2651)

Issue 135380043: Issue 3832: react sanely to ill-formed version strings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3832: react sanely to ill-formed version strings Contains commits Clean up Lilypond_version Converting to int seems strange, but we want version comparisons. Conversion to bool for checking validity seems nice. And bombing out because of invalid data to String_convert::dec2int seemed definitely non-nice. This version requires specifying at least major and minor version number explicitly separated by dots. It accepts a trailing dot, too. A trailing extra_patch_string after major.minor.patchlevel. is also accepted but not interpreted. Don't verify result of String_convert::dec2int The error behavior is not useful and triggers on things like "00".

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -19 lines) Patch
M flower/string-convert.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M lily/include/lilypond-version.hh View 3 chunks +5 lines, -1 line 0 comments Download
M lily/lexer.ll View 1 chunk +6 lines, -1 line 0 comments Download
M lily/lilypond-version.cc View 1 chunk +37 lines, -15 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b