Issue 13523049: Add support for setting MIDI pan position, and reverb and chorus levels

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13523049: Add support for setting MIDI pan position, and reverb and chorus levels

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by janek

Modified:
10 years, 7 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Add support for setting MIDI pan position, and reverb and chorus levels Allow customizing implementations of Translator::connect_to_context and Translator::disconnect_from_context New data types for controlling pan position, reverb and chorus levels Fix definition of default MIDI instrument in performer-init.ly

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+390 lines, -4 lines)			Patch
M	lily/audio-item.cc	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	lily/include/audio-item.hh	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	lily/include/lily-proto.hh	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	lily/include/midi-item.hh	View	2 chunks	+39 lines, -0 lines	0 comments	Download
M	lily/include/translator.hh	View	1 chunk	+2 lines, -3 lines	0 comments	Download
A	lily/midi-effect-performer.cc	View	1 chunk	+139 lines, -0 lines	0 comments	Download
M	lily/midi-item.cc	View	3 chunks	+62 lines, -0 lines	0 comments	Download
M	lily/staff-performer.cc	View	6 chunks	+75 lines, -0 lines	0 comments	Download
M	ly/performer-init.ly	View	5 chunks	+8 lines, -1 line	0 comments	Download
M	scm/define-context-properties.scm	View	1 chunk	+12 lines, -0 lines	0 comments	Download