Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(28)

Issue 135055: [PATCH] Move the Function*->allocated blocks map from the JITMemoryManager to the JITEmitter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by Jeffrey Yasskin
Modified:
14 years, 6 months ago
Reviewers:
natebegeman
CC:
llvm-commits_cs.uiuc.edu
Visibility:
Public.

Description

I'm making Functions auto-remove themselves from the JIT when they're destroyed. In this case, the Function needs to be removed from the JITEmitter, but the map recording which Functions need to be removed lived behind the JITMemoryManager interface, which made things difficult. This patch replaces the deallocateMemForFunction(Function*) method with a pair of methods deallocateFunctionBody(void *) and deallocateExceptionTable(void *) corresponding to the two startFoo/endFoo pairs. Patch at http://codereview.appspot.com/download/issue135055_1.diff. This slightly depends on http://codereview.appspot.com/132055 for ValueMap<>, but I can remove that if this gets approved first.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -75 lines) Patch
M include/llvm/ExecutionEngine/JITMemoryManager.h View 2 chunks +11 lines, -3 lines 0 comments Download
M lib/ExecutionEngine/JIT/JITEmitter.cpp View 4 chunks +17 lines, -2 lines 0 comments Download
M lib/ExecutionEngine/JIT/JITMemoryManager.cpp View 5 chunks +12 lines, -32 lines 0 comments Download
M unittests/ExecutionEngine/JIT/JITMemoryManagerTest.cpp View 4 chunks +39 lines, -38 lines 0 comments Download

Messages

Total messages: 1
Jeffrey Yasskin
14 years, 6 months ago (2009-10-20 07:11:09 UTC) #1
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b