Issue 13470043: Issue 1523: Parenthesizing breath marks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13470043: Issue 1523: Parenthesizing breath marks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by dak

Modified:
10 years, 6 months ago

Reviewers:
lemzwerg, Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Issue 1523: Parenthesizing breath marks Parenthesizing breath marks didn't work as expected. The parentheses were next to the breath mark, not around it. It would appear that just giving ParenthesesItem a non-empty (but zero) extent is enough to let it be placed correctly.

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	scm/define-grobs.scm	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lemzwerg

10 years, 8 months ago (2013-09-02 18:00:07 UTC) #2

LGTM, too.

BTW, do we have a regtest for this?  Given that the visual result before your
test is quite ugly, I suppose the answer is no...

Expand All Messages | Collapse All Messages