Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5672)

Issue 13328055: Avoid empty grammar rules using @$ for getting a source location (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by dak
Modified:
10 years, 5 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Avoid empty grammar rules using @$ for getting a source location Several rules use @$ for getting the source position from an empty rule, but Bison does not even provide a source position for empty rules. This patch fixes most cases by letting different non-empty rules assign the respective source positions. The case of #{ #} cannot be fixed in that manner since there is not a single token providing a source position in the whole production. Fixing this particular case would require a different technique.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M lily/parser.yy View 9 chunks +8 lines, -6 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b