Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1236)

Issue 133043: [PATCH] Allow Module deletion after function compiled. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by Jeffrey Yasskin
Modified:
14 years, 6 months ago
Reviewers:
evan.cheng
CC:
llvm-commits_cs.uiuc.edu
Visibility:
Public.

Description

Fix http://llvm.org/PR4822: allow module deletion after function compiled. When functions are compiled, they accumulate references in the JITResolver's stub maps. This patch removes those references when the functions are destroyed. It's illegal to destroy a Function when any thread may still try to call its machine code. This patch also updates r83987 to use ValueMap instead of explicit CallbackVHs and fixes a couple "do stuff inside assert()" bugs from r84522.

Patch Set 1 #

Patch Set 2 : Use ValueMap instead of explicit CallbackVHs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -57 lines) Patch
M include/llvm/ExecutionEngine/ExecutionEngine.h View 4 chunks +13 lines, -26 lines 0 comments Download
M lib/ExecutionEngine/ExecutionEngine.cpp View 9 chunks +23 lines, -19 lines 0 comments Download
M lib/ExecutionEngine/JIT/JITEmitter.cpp View 1 7 chunks +41 lines, -9 lines 0 comments Download
M unittests/ExecutionEngine/JIT/JITTest.cpp View 1 4 chunks +31 lines, -2 lines 0 comments Download
M unittests/ExecutionEngine/JIT/Makefile View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Jeffrey Yasskin
Patch at http://codereview.appspot.com/download/issue133043_1.diff
14 years, 6 months ago (2009-10-15 21:15:50 UTC) #1
Jeffrey Yasskin
14 years, 6 months ago (2009-10-22 22:43:55 UTC) #2
Evan, could you take a look?

New patch at http://codereview.appspot.com/download/issue133043_3001.diff
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b