Issue 13302048: Handle MultiMeasureRest direction in the part combiner like other elements

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 13302048: Handle MultiMeasureRest direction in the part combiner like other elements (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by dak

Modified:
10 years, 6 months ago

Reviewers:
Ian Hulin (gmail)

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Handle MultiMeasureRest direction in the part combiner like other elements Since issue 3307, they did not require special positioning.

Patch Set 3 : Changed regtest description #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -5 lines)			Patch
	A	input/regression/part-combine-mmrest-apart.ly	View	1 2	1 chunk	+35 lines, -0 lines	0 comments	Download
	M	lily/part-combine-iterator.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Ian Hulin (gmail)

texidoc string comment nit-pick, otherwise LGTM. https://codereview.appspot.com/13302048/diff/3001/input/regression/part-combine-mmrest-apart.ly File input/regression/part-combine-mmrest-apart.ly (right): https://codereview.appspot.com/13302048/diff/3001/input/regression/part-combine-mmrest-apart.ly#newcode5 input/regression/part-combine-mmrest-apart.ly:5: are positioned like ...

10 years, 7 months ago (2013-09-09 23:20:30 UTC) #2

dak

https://codereview.appspot.com/13302048/diff/3001/input/regression/part-combine-mmrest-apart.ly File input/regression/part-combine-mmrest-apart.ly (right): https://codereview.appspot.com/13302048/diff/3001/input/regression/part-combine-mmrest-apart.ly#newcode5 input/regression/part-combine-mmrest-apart.ly:5: are positioned like with normal split voices even when ...

10 years, 7 months ago (2013-09-10 08:13:24 UTC) #3

Changed regtest description

Expand All Messages | Collapse All Messages