Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(209)

Issue 13270048: parser.yy: allow "scalar" to be a negative literal number (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by dak
Modified:
10 years, 6 months ago
Reviewers:
Janek Warchol
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

parser.yy: allow "scalar" to be a negative literal number This makes the syntax of the value for \override (a hardwired syntax construct which accepts a "scalar") and \tweak (which is a music function accepting an expression of type "scheme?" possibly ending up as a negative number) more comparable.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M lily/parser.yy View 2 chunks +19 lines, -0 lines 4 comments Download

Messages

Total messages: 3
Janek Warchol
LGTM https://codereview.appspot.com/13270048/diff/1/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/13270048/diff/1/lily/parser.yy#newcode2328 lily/parser.yy:2328: | SCM_IDENTIFIER just curious: this SCM_IDENTIFIER is for ...
10 years, 8 months ago (2013-09-01 16:25:39 UTC) #1
dak
https://codereview.appspot.com/13270048/diff/1/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/13270048/diff/1/lily/parser.yy#newcode2328 lily/parser.yy:2328: | SCM_IDENTIFIER On 2013/09/01 16:25:39, Janek Warchol wrote: > ...
10 years, 8 months ago (2013-09-01 16:49:59 UTC) #2
Janek Warchol
10 years, 8 months ago (2013-09-01 17:06:18 UTC) #3
On 2013/09/01 16:49:59, dak wrote:
> https://codereview.appspot.com/13270048/diff/1/lily/parser.yy
> File lily/parser.yy (right):
> 
> https://codereview.appspot.com/13270048/diff/1/lily/parser.yy#newcode2328
> lily/parser.yy:2328: | SCM_IDENTIFIER
> On 2013/09/01 16:25:39, Janek Warchol wrote:
> > just curious: this SCM_IDENTIFIER is for things like #LEFT?
> 
> No.  It's for \xxx or $xxx kind of things not belonging in any other
> xxx_IDENTIFIER category.  #LEFT would be SCM_TOKEN instead (and is covered by
> embedded_scm_arg).

ah,ok.

> https://codereview.appspot.com/13270048/diff/1/lily/parser.yy#newcode2351
> lily/parser.yy:2351: // not of the kind requiring the full closedness
folderol.
> On 2013/09/01 16:25:39, Janek Warchol wrote:
> > Please avoid using uncommon words like "folderol".  They are funny, but only
> for
> > native speakers ;-)
> 
> The dictionary offers "humbug", "balderdash", "poppycock", "rubbish", "tripe",
> "trumpery", "trash", "wish-wash", "applesauce", "codswallop" as alternative
> words but most of them have not quite the same connotations, and it's not like
> those that are similar in meaning are in more common use.

uh, ok.

> While most code passages in LilyPond are documented without venturing beyond
the
> most common 1000 English words (mostly because they are not venturing beyond
any
> word at all), I think this should already be a notable improvement over the
> standard state.

Indeed, i've noticed the extensive comments and i do appreciate them!

Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b