Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2581)

Issue 132055: [PATCH] Add a ValueMap type, whose keys act like WeakVHs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by Jeffrey Yasskin
Modified:
14 years, 5 months ago
Reviewers:
CC:
llvm-commits_cs.uiuc.edu
Visibility:
Public.

Description

ValueMap<Value*, T> is safe to use even when keys get RAUWed and deleted during its lifetime. By default the keys act like WeakVHs, but users can pass a third template parameter to configure how updates work and whether to do anything beyond updating the map on each action. This type should make http://codereview.appspot.com/133043/diff/1/2 quite a bit simpler, but I haven't yet updated it so I could have missed something.

Patch Set 1 #

Patch Set 2 : Add lock support and fix a reentrant callback problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+682 lines, -0 lines) Patch
M docs/ProgrammersManual.html View 2 chunks +18 lines, -0 lines 0 comments Download
A include/llvm/ADT/ValueMap.h View 1 1 chunk +364 lines, -0 lines 0 comments Download
M include/llvm/Support/type_traits.h View 1 chunk +9 lines, -0 lines 0 comments Download
A unittests/ADT/ValueMapTest.cpp View 1 1 chunk +291 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Jeffrey Yasskin
14 years, 5 months ago (2009-10-17 07:42:54 UTC) #1
This breaks check-lit with the following error:

********************
UNRESOLVED: LLVM-Unit::ADT/Debug/ADTTests/ValueMapTest/1.NoFollowRAUW (103 of
4819)
******************** TEST
'LLVM-Unit::ADT/Debug/ADTTests/ValueMapTest/1.NoFollowRAUW' FAILED
********************
Exception during script execution:
Traceback (most recent call last):
  File "/Users/jyasskin/src/llvm/jit_del/src/utils/lit/lit.py", line 118, in
runTest
    self.litConfig)
  File "/Users/jyasskin/src/llvm/jit_del/src/utils/lit/TestFormats.py", line 58,
in execute
    out, err, exitCode = TestRunner.executeCommand(cmd)
  File "/Users/jyasskin/src/llvm/jit_del/src/utils/lit/TestRunner.py", line 23,
in executeCommand
    env=env)
  File
"/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/subprocess.py",
line 595, in __init__
    errread, errwrite)
  File
"/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/subprocess.py",
line 1092, in _execute_child
    raise child_exception
OSError: [Errno 20] Not a directory



I guess I'll have to figure out how to fix it before submitting.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b