Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(149)

Issue 132048: fix for setup.py of tryton client for use with tryton-windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 5 months ago by timitos
Modified:
14 years, 5 months ago
Reviewers:
h.goebel, ced1
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : setting relative path with pixbuf-query-loaders and copying all dlls from bin directory #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M setup.py View 1 1 chunk +14 lines, -0 lines 2 comments Download

Messages

Total messages: 3
ced1
http://codereview.appspot.com/132048/diff/1/2 File setup.py (right): http://codereview.appspot.com/132048/diff/1/2#newcode161 Line 161: pixbuf_loaders = file(os.path.join(dist_dir, 'etc', 'gtk-2.0', 'gdk-pixbuf.loaders'), 'r') Normally ...
14 years, 5 months ago (2009-10-16 19:10:20 UTC) #1
h.goebel
http://codereview.appspot.com/132048/diff/1/2 File setup.py (right): http://codereview.appspot.com/132048/diff/1/2#newcode161 Line 161: pixbuf_loaders = file(os.path.join(dist_dir, 'etc', 'gtk-2.0', 'gdk-pixbuf.loaders'), 'r') Use ...
14 years, 5 months ago (2009-10-17 11:04:59 UTC) #2
ced1
14 years, 5 months ago (2009-10-18 14:36:15 UTC) #3
http://codereview.appspot.com/132048/diff/6/2001
File setup.py (right):

http://codereview.appspot.com/132048/diff/6/2001#newcode164
Line 164: query_loaders = query_loaders.replace(gtk_dir + '/', '')
this line is unuseful

http://codereview.appspot.com/132048/diff/6/2001#newcode165
Line 165: query_loaders = query_loaders.replace(gtk_dir.replace(os.sep, '/') +
'/', '')
On previous version, it was replace by /target/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b