http://codereview.appspot.com/132048/diff/1/2 File setup.py (right): http://codereview.appspot.com/132048/diff/1/2#newcode161 Line 161: pixbuf_loaders = file(os.path.join(dist_dir, 'etc', 'gtk-2.0', 'gdk-pixbuf.loaders'), 'r') Normally there is key word to have relative path in loaders You should look in 1.2 version http://codereview.appspot.com/132048/diff/1/2#newcode190 Line 190: ): I don't like to have hard coded dll version. The best will be to copy all dll's that are in GTK/bin
http://codereview.appspot.com/132048/diff/1/2 File setup.py (right): http://codereview.appspot.com/132048/diff/1/2#newcode161 Line 161: pixbuf_loaders = file(os.path.join(dist_dir, 'etc', 'gtk-2.0', 'gdk-pixbuf.loaders'), 'r') Use "open()" instead of "file()", see <http://docs.python.org/library/functions.html#open> http://codereview.appspot.com/132048/diff/1/2#newcode161 Line 161: pixbuf_loaders = file(os.path.join(dist_dir, 'etc', 'gtk-2.0', 'gdk-pixbuf.loaders'), 'r') opening file in 'a'-mode would save close and re-open. http://codereview.appspot.com/132048/diff/1/2#newcode168 Line 168: pixbuf_loaders = file(os.path.join(dist_dir, 'etc', 'gtk-2.0', 'gdk-pixbuf.loaders'), 'w') file() -> open() http://codereview.appspot.com/132048/diff/1/2#newcode190 Line 190: ): On 2009/10/16 19:10:20, ced wrote: > I don't like to have hard coded dll version. > The best will be to copy all dll's that are in GTK/bin Copying would be the easiest. Otherwise use glob.glob()
http://codereview.appspot.com/132048/diff/6/2001 File setup.py (right): http://codereview.appspot.com/132048/diff/6/2001#newcode164 Line 164: query_loaders = query_loaders.replace(gtk_dir + '/', '') this line is unuseful http://codereview.appspot.com/132048/diff/6/2001#newcode165 Line 165: query_loaders = query_loaders.replace(gtk_dir.replace(os.sep, '/') + '/', '') On previous version, it was replace by /target/