http://codereview.appspot.com/13061/diff/1/2 File java/common/src/main/java/org/apache/shindig/common/xml/XmlUtil.java (right): http://codereview.appspot.com/13061/diff/1/2#newcode313 Line 313: try { On 2009/02/09 18:58:09, awiner wrote: > ...
15 years, 1 month ago
(2009-02-09 21:27:59 UTC)
#3
http://codereview.appspot.com/13061/diff/1/2
File java/common/src/main/java/org/apache/shindig/common/xml/XmlUtil.java
(right):
http://codereview.appspot.com/13061/diff/1/2#newcode313
Line 313: try {
On 2009/02/09 18:58:09, awiner wrote:
> why not just:
>
> try {
> parse(xml);
> } catch (XmlException e) {
> throw new RuntimeException(e);
> }
> ?
>
Done.
http://codereview.appspot.com/13061/diff/1/9
File java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/GadgetSpec.java
(right):
http://codereview.appspot.com/13061/diff/1/9#newcode56
Line 56: this.checksum = HashUtil.checksum(doc.toString().getBytes());
On 2009/02/09 18:58:09, awiner wrote:
> doc.toString() strikes me as an expensive operation.
It's modestly expensive, but these are always cached so it shouldn't be much of
an issue.
Issue 13061: Patch for SHINDIG-757
(Closed)
Created 15 years, 1 month ago by etnu00
Modified 14 years, 7 months ago
Reviewers:
Base URL: http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Comments: 5